coding icon indicating copy to clipboard operation
coding copied to clipboard

Add a proposal-accepted tag

Open ValarDragon opened this issue 7 years ago • 6 comments

Right now, there isn't a good way to discern via our tagging standards between a proposal we're debating on, and a proposal we've accepted and want to implement. I propose that we add a proposal-accepted tag, and that we remove the proposal tag once its clear that we want to go ahead with a proposal. Golang has one and I think it makes a lot of sense: https://github.com/golang/go/issues?q=is%3Aopen+is%3Aissue+label%3AProposal-Accepted

ValarDragon avatar Jul 11 '18 18:07 ValarDragon

I think this is a great idea! Do you think we should setup preliminaries for when a proposal can be "accepted? i.e., a thorough enough spec has been laid out with uses cases and potential implementation details.

alexanderbez avatar Jul 11 '18 18:07 alexanderbez

Thats a good point. I think that there should be some indication of how the proposal would be implemented. For non-minor changes, I think the API changes should have concrete proposals.

Not sure if we want to require a thorough spec, because I imagine a lot of proposals are going to be small things / on the scale where making a spec may not be worth the time. (Rather, updating the docs would be sufficient)

ValarDragon avatar Jul 11 '18 19:07 ValarDragon

@ValarDragon, just a detailed description will suffice...like an abstract. @ebuchman thoughts?

alexanderbez avatar Jul 11 '18 21:07 alexanderbez

That sounds good to me!

ValarDragon avatar Jul 13 '18 18:07 ValarDragon

Cool - just added to Cosmos-SDK

rigelrozanski avatar Jul 13 '18 18:07 rigelrozanski

The problem we run into is that tags just become a dumpster for all kinds of concerns. In tendermint we are trying to use tags now as classification what domain they belong to and of what nature they are (feature, bug, etc.). We just introduced a boad to track design documents and proposals.

xla avatar Jul 18 '18 12:07 xla