tenacity-legacy icon indicating copy to clipboard operation
tenacity-legacy copied to clipboard
verified publisher icon tenacityteam

PDBs not shipped on Windows

Open Be-ing opened this issue 4 years ago • 4 comments

Guidelines

  • [X] I have read the guidelines.

Version/Commit hash

any

Describe the bug.

Windows builds do not ship PDBs. It is very doubtful we will ever get backtraces from Windows users without this.

Expected behavior

PDBs for the application are shipped with the builds. PDBs for dependencies are not required.

OS

Windows

Additional context

https://github.com/tenacityteam/tenacity/pull/590#issuecomment-915184512

This issue is not a duplicate

  • [X] I have confirmed this issue isn't a duplicate.

Be-ing avatar Sep 08 '21 12:09 Be-ing

Compiling this on a fresh machine using Visual Studio 2022 seems to contain the PDF file. As long as it's the Debug build.

2021-09-19_12-57

n0toose avatar Sep 19 '21 10:09 n0toose

@panos The issue is that the PDB isn't included in the windows installer

AnotherFoxGuy avatar Sep 19 '21 11:09 AnotherFoxGuy

Yeah, I know, I'm just sort of trying to pinpoint the part that is responsible for including it. Well, for starters, it does exist.

n0toose avatar Sep 19 '21 13:09 n0toose

The reason is that you normally exclude PDB's from the installer, because without the sourcecode installed the PDB's are not useful

AnotherFoxGuy avatar Sep 19 '21 13:09 AnotherFoxGuy