Security-Hub icon indicating copy to clipboard operation
Security-Hub copied to clipboard

source CloudDiscoveryConnector changes

Open rishuzz opened this issue 1 year ago • 4 comments

since CloudDiscoveryConnector will pull all the assets across the cloud products, this fix basically remove non-aws assets

rishuzz avatar Mar 13 '24 12:03 rishuzz

While this may work, I think a couple of additional client-side checks need to happen to ensure that only AWS assets get fed in. Likely along the lines of simply checking to see if there is any aws attributes set.

SteveMcGrath avatar Mar 13 '24 14:03 SteveMcGrath

While this may work, I think a couple of additional client-side checks need to happen to ensure that only AWS assets get fed in. Likely along the lines of simply checking to see if there is any aws attributes set.

I have added check to only process assets which has any of the aws field is set

rishuzz avatar Mar 19 '24 08:03 rishuzz

@SteveMcGrath can you please review and do let me know if those checks looks fine.

rishuzz avatar Mar 20 '24 05:03 rishuzz