temporal icon indicating copy to clipboard operation
temporal copied to clipboard

GetTaskQueueUserData returns success on task queue closing

Open dnr opened this issue 1 year ago • 0 comments

What changed?

GetTaskQueueUserData returns a successful "no change" when the task queue is closing, instead of an Unavailable error.

Why?

  1. The caller will retry on both success and failure, so it doesn't really matter.
  2. Returning success avoids misleading logs about errors (this was improved in #5227 but still happens on service deployment/restart).
  3. More subtly, an unavailable error is actually retried by the server interceptor, which causes the task queue to be reloaded again. This can cause extra bouncing of task queues during deployment and increase latency. A success is not retried.

How did you test it?

changed unit test, tested locally with matching restarts

Potential risks

Is hotfix candidate?

dnr avatar Feb 16 '24 04:02 dnr