[Bug] Version info upgrade notification does not get cleared after cluster version upgrade

[bergundy]

Sample output from tctl admin cluster describe:

"versionInfo": {
  "current": {
   "version": "1.20.0",
   "releaseTime": "2023-02-17T21:48:00Z"
  },
  "recommended": {
   "version": "1.20.0",
   "releaseTime": "2023-02-17T21:48:00Z"
  },
  "alerts": [
   {
    "message": ":ringed_planet: A new release is available!",
    "severity": "Low"
   }
  ],
  "lastUpdateTime": "2023-03-22T08:54:54.838392383Z"
 }

Note that the lastUpdateTime is after the cluster was upgraded.

[smcgivern]

We're seeing something similar:

{
  "supportedClients": {
    "temporal-cli": "\u003c2.0.0",
    "temporal-go": "\u003c2.0.0",
    "temporal-java": "\u003c2.0.0",
    "temporal-php": "\u003c2.0.0",
    "temporal-server": "\u003c2.0.0",
    "temporal-typescript": "\u003c2.0.0",
    "temporal-ui": "\u003c3.0.0"
  },
  "serverVersion": "1.22.0",
  // snip
  "versionInfo": {
    "current": {
      "version": "1.20.3",
      "releaseTime": "2023-05-16T04:25:00Z"
    },
    "recommended": {
      "version": "1.21.2",
      "releaseTime": "2023-07-15T02:00:00Z"
    },
    "alerts": [
      {
        "message": "🪐 A new release is available!",
        "severity": "Low"
      }
    ],
    "lastUpdateTime": "2023-09-08T14:24:09.898917704Z"
  },
  "failoverVersionIncrement": "10",
  "initialFailoverVersion": "1"
}

Per https://community.temporal.io/t/cluster-upgrade-from-1-14-4-1-9-0-serverversion-changes-but-current-version-stays-1-14-4/6691/2, we should consider serverVersion to be accurate, but the cluster's versionInfo hasn't updated, which is confusing.

[g4ze]

hey @bergundy ! is this issue still up? if yes, could you pls elaborate a bit more on this issue?

[vaibhavyadav-dev]

@yycptt @bergundy I'm Taking this one. Thanks!

[AadiDev005]

Hi @bergundy, @vaibhavyadav-dev, and Temporal team! I’m new to contributing to Temporal and interested in helping with this bug to ensure the version upgrade notification clears correctly in the Go-based server codebase. I see @vaibhavyadav-dev submitted a fix in PR #7650. Is there still work needed, like testing, refinements, or additional changes? I’d love to dive into the version info logic and assist. Any guidance on next steps or the dev setup would be great! Excited to contribute.