sdk-python icon indicating copy to clipboard operation
sdk-python copied to clipboard

Insert guard clause for workflow.upsert_search_attributes on empty inputs

Open irdbl opened this issue 1 year ago • 4 comments

Fix for https://github.com/temporalio/sdk-python/issues/629

What was changed

Guard clause on workflow.upsert_search_attributes so SDK doesn't crash on empty input.

Why?

Spent 5 hours debugging an inscrutable error message.

Checklist

  1. Closes 629

  2. How was this tested: Pass empty list into upsert_search_attributes in a workflow.

  3. Any docs updates needed? No

irdbl avatar Sep 02 '24 22:09 irdbl

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 02 '24 22:09 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 02 '24 22:09 CLAassistant

@cretz Signed CLA!

irdbl avatar Sep 05 '24 02:09 irdbl

Thanks! We have a CI failure that is unrelated to this PR. Once it is fixed, we can come back and merge this.

cretz avatar Sep 05 '24 17:09 cretz