sdk-java icon indicating copy to clipboard operation
sdk-java copied to clipboard

DynamicWorkflow not taking in account WorkflowImplementationOptions

Open tsurdilo opened this issue 3 years ago • 6 comments

    WorkflowImplementationOptions options =
    WorkflowImplementationOptions.newBuilder()
        .setFailWorkflowExceptionTypes(NullPointerException.class)
        .build();
   worker.registerWorkflowImplementationTypes(options, DynamicGreetingWorkflowImpl.class);

throwing NullPointerException inside Dynamic workflow (workflow that implements DynamicWorkflow interface) does not take in account WorkflowImplementationOptions and will not fail when NPE is thrown. This works fine for "normal" workflow impls which would fail at this point.

tsurdilo avatar Jun 01 '22 15:06 tsurdilo

I ran into this bug today. Any ETA for a fix?

drewhoskins-stripe avatar Nov 16 '22 23:11 drewhoskins-stripe

@drewhoskins-stripe Not yet, Drew. But I will put it up for prioritization or may take it during the next Bulk Bug Squash that I am able to do.

Spikhalskiy avatar Nov 17 '22 01:11 Spikhalskiy

Thanks!

drewhoskins-stripe avatar Nov 17 '22 17:11 drewhoskins-stripe

@Spikhalskiy Any updates on this one?

jeffschoner-stripe avatar May 24 '23 18:05 jeffschoner-stripe

No update at this time

Quinn-With-Two-Ns avatar May 24 '23 18:05 Quinn-With-Two-Ns

I have the same problem, do we have a plan to solve it?

zuodimiaoyun avatar Mar 21 '24 02:03 zuodimiaoyun