samples-go icon indicating copy to clipboard operation
samples-go copied to clipboard

[Feature Request] Add sample for client TLS config

Open tsurdilo opened this issue 3 years ago • 4 comments

I was not able to find a sample on how to set up client options with TSL enabled. Does not have to be running, could be just a config example that users can cut/paste, similar to what we have in java samples: https://github.com/temporalio/samples-java/blob/main/src/main/java/io/temporal/samples/ssl/SslEnabledWorker.java

Related user forum thread: https://community.temporal.io/t/help-how-to-create-a-client-with-tls/4287

tsurdilo avatar Mar 28 '22 02:03 tsurdilo

TLS is a Go concept not a Temporal one. The client.ConnectionOptions.TLS configuration value is a Go TLS config not a Temporal one.

Having said that, we can have a sample showing how to use Go TLS.

cretz avatar Mar 28 '22 14:03 cretz

@cretz I would love to contribute to this project by taking up this issue. Let me know how the process looks like :)

YashishDua avatar Apr 03 '22 09:04 YashishDua

In this case, I was thinking a new dir called mtls w/ a sample like the helloworld one but the starter/worker code uses mtls via keys stored here in the repo (see the serverjwtauth sample) and the README would explain how to setup mTLS.

If you want to take this on, a simple PR is perfect.

cretz avatar Apr 04 '22 19:04 cretz

I am very interested in such an example. I'm keeping an eye on this issue. Thanks guys

gmendoza-wenance avatar Apr 08 '22 16:04 gmendoza-wenance