maru icon indicating copy to clipboard operation
maru copied to clipboard

Enable custom pod annotations

Open arihantsethia opened this issue 1 year ago • 1 comments

What was changed

Allows users to define custom pod level annotations

Why?

This unlocks the capbility to provide additional configuration option for external systems (e.g. istio sidecar resources)

Checklist

How was this tested: Validated charts being generated with annotations when configured.

with podAnnotations :

apiVersion: apps/v1
kind: Deployment
metadata:
  name: maru-temporal-bench
  labels:
    ...
spec:
  replicas: 2
  selector:
    matchLabels:
      app.kubernetes.io/name: temporal-bench
      app.kubernetes.io/instance: maru
  template:
    metadata:
      labels:
        app.kubernetes.io/name: temporal-bench
        app.kubernetes.io/instance: maru
      annotations:
        prometheus.io/job: temporal-bench
        prometheus.io/scrape: 'true'
        prometheus.io/port: '9090'
        sidecar.istio.io/proxyCPU: 200m
        sidecar.istio.io/proxyMemory: 512Mi
        sidecar.istio.io/proxyMemoryLimit: 512Mi

without annotations

apiVersion: apps/v1
kind: Deployment
metadata:
  name: maru-temporal-bench
  labels:
    ...
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: temporal-bench
      app.kubernetes.io/instance: maru
  template:
    metadata:
      labels:
        app.kubernetes.io/name: temporal-bench
        app.kubernetes.io/instance: maru
      annotations:
        prometheus.io/job: temporal-bench
        prometheus.io/scrape: 'true'
        prometheus.io/port: '9090'

arihantsethia avatar Mar 16 '24 09:03 arihantsethia

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 16 '24 09:03 CLAassistant