documentation icon indicating copy to clipboard operation
documentation copied to clipboard
verified publisher icon temporalio

Python: Added paragraph that warns about pytest.fixture(scope="session") with test server

Open edmondop opened this issue 1 year ago • 1 comments

What does this PR do?

Addresses #3111 . When running tests in a project I noticed:

  • Time skipping wasn't working even if it was enabled
  • samples-python test never reuse the same workflow environment with timeskipping

This additional paragraph should warn developers familiar with pytest.fixtures not to use the scope session for caching the workflow environment

edmondop avatar Sep 28 '24 16:09 edmondop

Created SDK-2941 to review

fairlydurable avatar Oct 10 '24 19:10 fairlydurable

Thanks, @cretz. Back to you @edmondop

fairlydurable avatar Dec 02 '24 16:12 fairlydurable

I have accepted all @cretz suggestion, thank you @cretz . I see two workflows are not passing, do I need to do something else?

edmondop avatar Dec 02 '24 16:12 edmondop

@edmondop Thanks for all your work on this. Please ping me and let me know when it is ready to move forward. Cheers!

fairlydurable avatar Dec 05 '24 21:12 fairlydurable

@cretz @edmondop Just touching base to check the status of this PR. Thank you both.

fairlydurable avatar Jan 10 '25 17:01 fairlydurable

@fairlydurable - sorry I missed your comment until now. I think https://github.com/temporalio/documentation/pull/3113/files#r1866332621 still needs to be addressed

cretz avatar Jan 16 '25 23:01 cretz

Closing this one.

flippedcoder avatar Oct 07 '25 14:10 flippedcoder