api
api copied to clipboard
[Feature Request] Move/remove third party protos to a separate place instead of root
Describe the solution you'd like
Other users protoc from the root of this repo. When https://github.com/temporalio/api/commit/108b40ae508505b64f19ccbe2fdbcd304081391b was done, we put google-based proto dependencies at the same path as our own assuming that all users were ok with using these google protos instead of their own (e.g. from https://github.com/protocolbuffers/protobuf/tree/main/src/google/protobuf).
We probably need to either:
- Put the third party references where the
protocis actually run (e.g.api-go) and only embed them here when testing
or:
- Move
google/apitothirdparty/google-api/google/api - Move
google/protobuftothirdparty/google-protobuf/google/protobuf - Add
-I thirdparty/google-apiand-I thirdparty/google-protobufto ourprotoc - Confirm the fact that
thirdpartyis nested under our root is ok and can easily be ignored by mostprotocuse