tempest-framework icon indicating copy to clipboard operation
tempest-framework copied to clipboard

Adds filesystem

Open aidan-casey opened this issue 1 year ago • 2 comments

Closes tempestphp/tempest-core#2 when merged.

aidan-casey avatar Mar 06 '24 15:03 aidan-casey

Pull Request Test Coverage Report for Build 8336743704

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 19 of 141 (13.48%) changed or added relevant lines in 16 files are covered.
  • 91 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-1.5%) to 79.56%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Filesystem/Exception/FileAlreadyExists.php 0 1 0.0%
src/Filesystem/Exception/UnableToCloseStream.php 0 3 0.0%
src/Filesystem/Exception/UnableToCopyFile.php 0 3 0.0%
src/Filesystem/Exception/UnableToCreateDirectory.php 0 3 0.0%
src/Filesystem/Exception/UnableToDeleteDirectory.php 0 3 0.0%
src/Filesystem/Exception/UnableToMoveFile.php 0 3 0.0%
src/Filesystem/Exception/UnableToOpenStream.php 0 3 0.0%
src/Filesystem/Exception/UnableToReadFile.php 0 3 0.0%
src/Filesystem/Exception/UnableToWriteFile.php 0 3 0.0%
src/Filesystem/FilesystemManager.php 0 3 0.0%
<!-- Total: 19 141
Files with Coverage Reduction New Missed Lines %
src/Mapper/ArrayToObjectMapper.php 1 99.06%
src/Discovery/DiscoveryDiscovery.php 2 72.73%
src/Exceptions/ConsoleExceptionHandler.php 2 76.0%
src/Http/GenericResponseSender.php 4 77.78%
src/Container/InMemoryContainerLog.php 5 76.19%
src/Clock/MockClock.php 5 50.0%
src/Http/IsResponse.php 7 78.79%
src/Testing/Http/TestResponseHelper.php 8 90.12%
src/Http/GenericRouter.php 10 89.22%
src/Testing/Console/TestConsoleHelper.php 10 34.43%
<!-- Total: 91
Totals Coverage Status
Change from base Build 8173109506: -1.5%
Covered Lines: 2133
Relevant Lines: 2681

💛 - Coveralls

coveralls avatar Mar 06 '24 15:03 coveralls

when merged.

Can I?? 😁

Left some comments, only afterwards I noticed it was still draft 🫣

brendt avatar Mar 10 '24 04:03 brendt

@aidan-casey wdyt we're going to do with this? In the current architecture it should be moved to tempest/core and probably needs some more finetuning. We could also close it for now and revisit it at a later point. I don't have a strong opinion either way.

brendt avatar May 30 '24 17:05 brendt

I'm gonna close this one. Let's reconsider at a later point

brendt avatar Aug 06 '24 07:08 brendt