docker_files icon indicating copy to clipboard operation
docker_files copied to clipboard

This docker-compose file is completely broken

Open amalic opened this issue 7 years ago • 1 comments

  • The .env which is being mounted does not exist.
  • Usage of $PWD doesn't make any sense since docker-compose can resolve relative paths.
  • An environment variable called $ROOT is being used and you expect a cert folder in it. In the nginx sub-folder you try to use letsencrypt. It would be smarter to not do https in your web-application but rather delegate it to something like jwilder/nginx-proxy with letsencrypt-companion
  • There is no need to map all exposed ports. I would recommend to only map port 80 of the web application. Within the docker-compose infrastructure all containers can access each other via network using the service-name from the docker-compose file.

amalic avatar Nov 21 '18 00:11 amalic

Theres a bunch of stuff wrong with the docker-compose file like how the compose file is pulling a broken and outdated docker container image. There's really no indication that the main branch of the app is stable it seems and the main developer doesn't seem to be in their own Gitter.im channel. I PR'd a few adjustments recently.

Leopere avatar Feb 08 '19 04:02 Leopere