teletrace icon indicating copy to clipboard operation
teletrace copied to clipboard

✨ Spans Search - Search/autocomplete is case-sensitive

Open OfirD55 opened this issue 3 years ago • 6 comments

Cc: @Madina-Mamysheva @shaqued

Hi

Pain

Search/autocomplete is case-sensitive, that's why some values written in all-caps or having a capital letter are overlook while searching. For example, HTTP/GET/POST can't be found if user types "get" instead of "GET".

Steps To Reproduce

  • Go to https://app.lupaproject.io/ or https://app.embedded.lupaproject.io/
  • Search for GET, POST or any other value having a capital letter grpc.hipstershop.ProductCatalogService/GetProduct (sidebar/custom filters)
  • Pay attention that there is no results if to type "get" instead of "GET"

Suggested Solution

Remove case-sensitive behavior from the search/autocomplete component. The search/autocomplete shouldn't be a case-sensitive, so users would get more accurate results.

Screenshots

https://user-images.githubusercontent.com/55341028/213913566-fe80a8be-b877-489b-9691-712187965603.mov

Thanks!

OfirD55 avatar Jan 22 '23 11:01 OfirD55

We closed the bug #1122 and opened this under Feature Request as requested

OfirD55 avatar Jan 22 '23 11:01 OfirD55

Hi @haimrait , i'd love to take a stab at this

galbash avatar Apr 03 '23 07:04 galbash

I will only change the component to be not case sensitive, not changing behavior on the backend (if the user still chooses the incorrect case despite suggestion, he will not get results)

galbash avatar Apr 03 '23 07:04 galbash

This actually have to happen in the backend. @haimrait i'll change the api to be case insensitive

galbash avatar Apr 03 '23 08:04 galbash

@galbash yea I am agree with you I will add backend label

haimrait avatar Apr 03 '23 09:04 haimrait

up for grabs again

galbash avatar Apr 03 '23 10:04 galbash