promiseBaseURI is not defined

Open marciotc opened this issue 3 years ago • 4 comments

the line 205 in ReadFileChunkLoadingRuntimeModule.js should be changed to: `rpcLoad( promiseBaseURI ? await promiseBaseURI : baseURI }, ${

Jul 25 '22 20:07 marciotc

Hello @marciotc, the promise is resolved at runtime and not at build time so it must be inlined with the template string.

But you are also right, I forgot to replace the HMR part with the new option like in the loading part. :facepalm:

If you open a PR, I suppose @telenko would accept the fix.

Jul 26 '22 10:07 noreiller

Yes. That's why the error occurs. It's missing escapes. This is a code generator, but it's looking for definitions in the building scope, not runtime.

Aug 02 '22 19:08 marciotc

@marciotc @telenko I fixed this in my PR #16

Aug 11 '22 07:08 noreiller

what is the point and purpose of promiseBaseURI variable?

Dec 08 '23 10:12 woss