scale icon indicating copy to clipboard operation
scale copied to clipboard

preselected tab in tab-nav

Open tshimber opened this issue 1 year ago • 4 comments

Fixes https://github.com/telekom/scale/issues/2282. No new functionality, just storybook extended

  • an example provided in 'Docs' part, no extra description
  • tab-nav template added to html

UPD 25.06.: I've added fixes for case when we disable tabs from code and currently selected tab gots disabled. now first enabled tab gots selected, without the fix in such cases tab-header is deselected, but no new tab is getting selected.

tshimber avatar Jun 11 '24 09:06 tshimber

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
Latest commit b88c2fe6f2011cd618df6da3bf5d46bc06bcae02
Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/671f9d8f1b50650008eb7574
Deploy Preview https://deploy-preview-2320--marvelous-moxie-a6e2fe.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 11 '24 09:06 netlify[bot]

@tshimber thanks for the PR. LGTM.

@maomaoZH thank you! but unfortunately it doesn't work in deployed version🫠 I try to understand now, how these storybook templates are working. sorry, i'll put the draft mark now..

tshimber avatar Jun 11 '24 10:06 tshimber

@tshimber Scale is still using storybook 7. So it is a bit tricky to add story.

maomaoZH avatar Jun 11 '24 10:06 maomaoZH

@tshimber Scale is still using storybook 7. So it is a bit tricky to add story.

I need to add fixes to current) I've understood how templates in storybook are working, so now it seems fine. Could you take a look again? Maybe you have some comments to naming or smth else?

Here's how it looks now: image

tshimber avatar Jun 11 '24 12:06 tshimber