iotagent-node-lib icon indicating copy to clipboard operation
iotagent-node-lib copied to clipboard
verified publisher icon telefonicaid

Add Node v18 to CI test

Open mapedraza opened this issue 3 years ago • 3 comments

This PR adds Node v18 to the CI unit tests

mapedraza avatar May 03 '22 11:05 mapedraza

Should Lint steps need to be updated to a newer version?. I.E: https://github.com/telefonicaid/iotagent-node-lib/blob/1e89c6728652e37e202c47facc8d16d04593a7bd/.github/workflows/ci.yml#L17

https://github.com/telefonicaid/iotagent-node-lib/blob/1e89c6728652e37e202c47facc8d16d04593a7bd/.github/workflows/ci.yml#L37

mapedraza avatar May 03 '22 11:05 mapedraza

Should Lint steps need to be updated to a newer version?. I.E:

https://github.com/telefonicaid/iotagent-node-lib/blob/1e89c6728652e37e202c47facc8d16d04593a7bd/.github/workflows/ci.yml#L17

https://github.com/telefonicaid/iotagent-node-lib/blob/1e89c6728652e37e202c47facc8d16d04593a7bd/.github/workflows/ci.yml#L37

It seems to be a good idea. The newest possible.

fgalan avatar May 03 '22 11:05 fgalan

I have merged master into this PR in commit 220058a to incorporate the changes in PR https://github.com/telefonicaid/iotagent-node-lib/pull/1250 (MongoDB driver migration to 4.x) to check if they could solve the Node v18 tests, but it seems the issue persists :(

fgalan avatar Jun 21 '22 11:06 fgalan

Maybe we can close this PR due to https://github.com/telefonicaid/iotagent-node-lib/pull/1333

AlvaroVega avatar Apr 04 '23 06:04 AlvaroVega

As noted by @AlvaroVega, closed due to #1333

mapedraza avatar Apr 04 '23 07:04 mapedraza