iotagent-node-lib icon indicating copy to clipboard operation
iotagent-node-lib copied to clipboard
verified publisher icon telefonicaid

Added Feature/config groups

Open Sunny-NEC opened this issue 4 years ago • 3 comments

Added code for iot/configGroups (https://github.com/telefonicaid/iotagent-node-lib/issues/752)

Sunny-NEC avatar Feb 06 '22 17:02 Sunny-NEC

Please solve the conflict in CHANGES_NEXT_RELEASE so unit tests can automatically run in your PR.

fgalan avatar Feb 07 '22 13:02 fgalan

It seems this is the fifth incarnation of the cgroups PR:

  • First: #775
  • Second: #780
  • Third: #922
  • Fourth: #954
  • Fifth (this one): #1198

Just in case it can be useful (mainly for taking into account all the potential feedback spreaded over them)

fgalan avatar Feb 07 '22 15:02 fgalan

Additionally to the comments on the code, this PR changes 20 files, in opposite to previous PR #954 which modifies 31 files. Some of them are related with NGSIv1 tests but not all of them. Could you elaborate why?

The files not covered in this PR but with changes in 954 and are not NGSv1 related are:

  • lib/fiware-iotagent-lib.js
  • test/unit/ngsiv2/provisioning/device-provisioning-api_test.js (please add the comment, could be useful)
  • test/unit/ngsiv2/provisioning/singleConfigurationMode-test.js (please add the comment, could be useful)

mapedraza avatar Feb 07 '22 17:02 mapedraza

overpassed by https://github.com/telefonicaid/iotagent-node-lib/pull/1375#issuecomment-1736903343

mapedraza avatar Sep 27 '23 13:09 mapedraza