operator icon indicating copy to clipboard operation
operator copied to clipboard

Fix warning on OCP 4.11 cluster for operator install

Open piyush-garg opened this issue 3 years ago • 12 comments

Operator make apply is throwing warning on new OCP 4.11 cluster because of the restricted PSA getting available by default

This will fix the warning on 4.11

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Release Notes

Fix warning on OCP 4.11 cluster for operator install

piyush-garg avatar May 26 '22 05:05 piyush-garg

shall we also this to all deployments created by operator? if the deployment doesn't have it..

sm43 avatar May 26 '22 05:05 sm43

shall we also this to all deployments created by operator? if the deployment doesn't have it..

I tested and checked, and it is happening for all components deployment also. How do we want to handle this? Through transformer or have it got added in different components etc? cc @sm43 @nikhil-thomas @vdemeester

piyush-garg avatar May 27 '22 11:05 piyush-garg

shall we also this to all deployments created by operator? if the deployment doesn't have it..

I tested and checked, and it is happening for all components deployment also. How do we want to handle this? Through transformer or have it got added in different components etc? cc @sm43 @nikhil-thomas @vdemeester

Probably yes. We need to ensure we have those set correctly on the thing we support, no matter what upstream does.

vdemeester avatar May 30 '22 06:05 vdemeester

/grooming

piyush-garg avatar Jun 02 '22 11:06 piyush-garg

@piyush-garg interesting, it doesn't look like "root" label work with the command... maybe we could have a triage one ? 🤔

/triage grooming

vdemeester avatar Jun 02 '22 12:06 vdemeester

/triage wg-discuss This one seems to exist 🤔

vdemeester avatar Jun 02 '22 12:06 vdemeester

/project "Tekton Operator working group"

vdemeester avatar Jun 02 '22 12:06 vdemeester

@vdemeester: There is no maintainer team for this repo or org.

In response to this:

/project "Tekton Operator working group"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Jun 02 '22 12:06 tekton-robot

shall we merge this? @piyush-garg and handle for components in another pr ? or are you gonna update this one?

sm43 avatar Jun 27 '22 03:06 sm43

shall we merge this? @piyush-garg and handle for components in another pr ? or are you gonna update this one?

I am updating this one

piyush-garg avatar Jun 27 '22 10:06 piyush-garg

@piyush-garg what is the status here ?

vdemeester avatar Jul 11 '22 16:07 vdemeester

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Sep 22 '22 09:09 tekton-robot

/lgtm

vdemeester avatar Sep 27 '22 12:09 vdemeester

/cherrypick release-v0.60.x

concaf avatar Oct 03 '22 10:10 concaf

@concaf: new pull request created: #1083

In response to this:

/cherrypick release-v0.60.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Oct 03 '22 10:10 tekton-robot