operator icon indicating copy to clipboard operation
operator copied to clipboard
verified publisher icon tektoncd

Run rbac createresources for namespaces concurrently to avoid slowness

Open jkhelil opened this issue 1 year ago • 8 comments

Changes

  • Process rbac resource creation for openshift namespace reconciliation concurrently to avoid slowness on clusters with high number of namespace
  • Avoid blocking the reconciliation loop on error, when errors happen on namespace rbac resource reconciliation for openshift
  • Add unit tests to createRessource in rbac.go

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Run make test lint before submitting a PR
  • [ ] Includes tests (if functionality changed/added)
  • [ ] Includes docs (if user facing)
  • [ ] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

jkhelil avatar Jun 19 '24 08:06 jkhelil

/retest

jkandasa avatar Jun 21 '24 04:06 jkandasa

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/common.go 0.0% 54.8% 54.8
pkg/reconciler/openshift/tektonconfig/rbac.go 0.0% 43.4% 43.4

tekton-robot avatar Jun 21 '24 08:06 tekton-robot

@jkandasa @piyush-garg can you lgtm please ?

jkhelil avatar Jun 21 '24 09:06 jkhelil

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/common.go 0.0% 54.8% 54.8
pkg/reconciler/openshift/tektonconfig/rbac.go 0.0% 43.4% 43.4

tekton-robot avatar Jun 24 '24 08:06 tekton-robot

@jkandasa @piyush-garg Please have a look to my PR

jkhelil avatar Jun 26 '24 11:06 jkhelil

@piyush-garg @vdemeester can you please review?

jkandasa avatar Jul 03 '24 07:07 jkandasa

/test pull-tekton-operator-build-tests

jkhelil avatar Jul 03 '24 15:07 jkhelil

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/common.go 0.0% 54.8% 54.8
pkg/reconciler/openshift/tektonconfig/rbac.go 0.0% 42.4% 42.4

tekton-robot avatar Jul 05 '24 13:07 tekton-robot

/test pull-tekton-operator-build-tests

jkhelil avatar Jul 05 '24 14:07 jkhelil

/test pull-tekton-operator-build-tests

jkhelil avatar Jul 05 '24 14:07 jkhelil

/test pull-tekton-operator-build-tests

jkhelil avatar Jul 05 '24 14:07 jkhelil

/test pull-tekton-operator-build-tests

jkhelil avatar Jul 05 '24 16:07 jkhelil

/test pull-tekton-operator-build-tests

jkhelil avatar Jul 06 '24 15:07 jkhelil

/test pull-tekton-operator-build-tests

jkhelil avatar Jul 07 '24 07:07 jkhelil

/test pull-tekton-operator-build-tests

jkhelil avatar Jul 08 '24 07:07 jkhelil

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/common.go 0.0% 54.8% 54.8
pkg/reconciler/openshift/tektonconfig/rbac.go 0.0% 42.4% 42.4

tekton-robot avatar Jul 10 '24 06:07 tekton-robot

/retest

piyush-garg avatar Jul 13 '24 21:07 piyush-garg

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/common.go 0.0% 54.8% 54.8
pkg/reconciler/openshift/tektonconfig/rbac.go 0.0% 42.4% 42.4

tekton-robot avatar Jul 22 '24 07:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/common.go 0.0% 54.8% 54.8
pkg/reconciler/openshift/tektonconfig/rbac.go 0.0% 43.1% 43.1

tekton-robot avatar Jul 24 '24 11:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/common.go 0.0% 54.8% 54.8
pkg/reconciler/openshift/tektonconfig/rbac.go 0.0% 45.0% 45.0

tekton-robot avatar Jul 24 '24 13:07 tekton-robot

Changes

  • Process rbac resource creation for openshift namespace reconciliation concurrently to avoid slowness on clusters with high number of namespace
  • Avoid blocking the reconciliation loop on error, when errors happen on namespace rbac resource reconciliation for openshift

I am in this situation, thanks for this pull request 👍

Diliz avatar Jul 25 '24 06:07 Diliz

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/common.go 0.0% 54.8% 54.8
pkg/reconciler/openshift/tektonconfig/rbac.go 0.0% 45.0% 45.0

tekton-robot avatar Jul 26 '24 07:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/openshift/tektonconfig/common.go 0.0% 54.8% 54.8
pkg/reconciler/openshift/tektonconfig/rbac.go 0.0% 45.2% 45.2

tekton-robot avatar Jul 26 '24 07:07 tekton-robot

/approve

cc @jkandasa

piyush-garg avatar Jul 29 '24 18:07 piyush-garg

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa, piyush-garg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [jkandasa,piyush-garg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Jul 30 '24 02:07 tekton-robot