Changes

Adds webhook configuration options(FailurePolicy, TimeoutSeconds, SideEffects) to tektonConfig additional options

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[x] Run make test lint before submitting a PR
[x] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

Adds webhook configuration options(FailurePolicy, TimeoutSeconds, SideEffects) to tektonConfig additional options

Apr 29 '24 15:04 jkhelil

Hi @jkhelil. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Apr 29 '24 15:04 tekton-robot

/ok-to-test

Apr 29 '24 17:04 jkandasa

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

Apr 29 '24 17:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

Apr 30 '24 06:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

Apr 30 '24 07:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

Apr 30 '24 10:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

Apr 30 '24 11:04 tekton-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jkandasa]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

May 07 '24 05:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

May 07 '24 06:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

May 07 '24 07:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

May 13 '24 07:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go	42.5%	43.2%	0.7
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go	83.3%	85.1%	1.8
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

May 21 '24 08:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go	42.5%	43.2%	0.7
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go	83.3%	85.1%	1.8
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

May 21 '24 09:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go	42.5%	43.2%	0.7
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go	83.3%	85.1%	1.8
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

May 22 '24 07:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonconfig_validation.go	42.5%	43.2%	0.7
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go	83.3%	85.1%	1.8
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

May 22 '24 08:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/additional_options_validation.go	Do not exist	88.9%
pkg/apis/operator/v1alpha1/tektonconfig_validation.go	42.5%	43.2%	0.7
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go	83.3%	84.2%	0.9
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

May 22 '24 11:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/additional_options_validation.go	Do not exist	88.9%
pkg/apis/operator/v1alpha1/tektonconfig_validation.go	42.5%	43.2%	0.7
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go	83.3%	84.2%	0.9
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

May 22 '24 12:05 tekton-robot

@piyush-garg @savitaashture can you have a fresh look please ?

May 22 '24 12:05 jkhelil

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/additional_options_validation.go	Do not exist	88.9%
pkg/apis/operator/v1alpha1/tektonconfig_validation.go	42.5%	44.4%	1.9
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go	83.3%	84.2%	0.9
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

May 31 '24 13:05 tekton-robot

@savitaashture @piyush-garg @jkandasa Can you retake a look/lgtm please ?

May 31 '24 14:05 jkhelil

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/additional_options_validation.go	Do not exist	88.9%
pkg/apis/operator/v1alpha1/tektonconfig_validation.go	42.5%	45.7%	3.1
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go	83.3%	84.2%	0.9
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

May 31 '24 14:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/additional_options_validation.go	Do not exist	88.9%
pkg/apis/operator/v1alpha1/tektonconfig_validation.go	42.5%	45.7%	3.1
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go	83.3%	84.2%	0.9
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

Jun 04 '24 11:06 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/additional_options_validation.go	Do not exist	88.9%
pkg/apis/operator/v1alpha1/tektonconfig_validation.go	42.5%	45.7%	3.1
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go	83.3%	84.2%	0.9
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

Jun 06 '24 07:06 tekton-robot

LGTM

Thank you @jkhelil

Jun 06 '24 07:06 savitaashture

The following is the coverage report on the affected files. Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/additional_options_validation.go	Do not exist	88.9%
pkg/apis/operator/v1alpha1/tektonconfig_validation.go	42.5%	45.7%	3.1
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go	83.3%	84.2%	0.9
pkg/reconciler/common/transformer_additional_options.go	87.5%	87.1%	-0.4

Jun 06 '24 10:06 tekton-robot

/lgtm

Jun 07 '24 12:06 piyush-garg

/retest

Jun 10 '24 06:06 jkhelil

Add webhookconfiguration options to tektonConfig additional options

Changes

Submitter Checklist

Release Notes