operator icon indicating copy to clipboard operation
operator copied to clipboard
verified publisher icon tektoncd

Link broken on tektoncd/operator/blob/main/DEVELOPMENT.md

Open T3-git opened this issue 2 years ago • 9 comments

Expected Behavior

On https://github.com/tektoncd/operator/blob/main/DEVELOPMENT.md when clicking the link in

To setup a cluster with GKE:

Install required tools and setup GCP project (You may find it useful to save the ID of the project in an environment variable (e.g. PROJECT_ID).

you will be lead to a file not found page.

Actual Behavior

This link should link to a markdown document describing Knative-with-GKE.md or if this document no longer exists, a replacement solution should be provided.

Steps to Reproduce the Problem

  1. Open DEVELOPMENT.md
  2. Click the link under to setup a cluster with GKE

T3-git avatar Dec 28 '23 05:12 T3-git

/kind documentation /good-first-issue

T3-git avatar Dec 28 '23 05:12 T3-git

@T3-git: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/kind documentation /good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Dec 28 '23 05:12 tekton-robot

Did a little digging and looks like the doc was removed in https://github.com/knative/docs/pull/2170

SD-13 avatar Dec 28 '23 13:12 SD-13

Do we have to remove that part?

abhayguptas avatar Dec 30 '23 03:12 abhayguptas

Maybe I wasnt the best canidate to report this(I'm, also new). Seems like @SD-13 found thats its been moved to one large file if I read correctly so I would assume we would verify that section is still there and update the link accordingly. SD-13 might be working this though since they tracked down the commit.

T3-git avatar Dec 30 '23 03:12 T3-git

I think we should replace the old link with this README if we don't want to refactor this doc.

SD-13 avatar Dec 30 '23 09:12 SD-13

Yes, It would be great @SD-13!

justankiit avatar Dec 31 '23 18:12 justankiit

I will open a PR for it!

SD-13 avatar Jan 01 '24 04:01 SD-13

@T3-git I've added PR linked with this issue: https://github.com/knative/docs/pull/6151 please review

Srish-ty avatar Oct 28 '24 02:10 Srish-ty