chains icon indicating copy to clipboard operation
chains copied to clipboard

Discuss whether Chains should check artifact's digest in TaskRun

Open ywluogg opened this issue 3 years ago • 2 comments

Per the discussion thread, it worths more discussions if Chains should check the existence of the artifact. Here are a few things we are looking:

  1. if digest matches the uri
  2. if the uri exists

One idea is to not let Chains does this job, but rather, relying on trusted tasks / resources to have a step to verify the above stuff, and trusted task can guarantee the task is not modified and the artifact is produced as expected. SPIRE, on the other hand, garantees the TaskRun hasn't been modified after the execution.

The other idea is that Chains can check one or more of the items listed above

ywluogg avatar Jul 08 '22 14:07 ywluogg

@wlynch @priyawadhwa

ywluogg avatar Jul 11 '22 15:07 ywluogg

From the slsa doc it seems like this isn't required for level 2:

The provenance MUST identify the output artifact via at least one cryptographic hash. The provenance MAY provide multiple identifying cryptographic hashes using different algorithms. When only one hash is provided, the RECOMMENDED algorithm is SHA-256 for cross-system compatibility. If another algorithm is used, it SHOULD be resistant to collisions and second preimages.

priyawadhwa avatar Jul 25 '22 22:07 priyawadhwa

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Oct 23 '22 23:10 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Nov 22 '22 23:11 tekton-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Dec 22 '22 23:12 tekton-robot

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Dec 22 '22 23:12 tekton-robot