pgoapi icon indicating copy to clipboard operation
pgoapi copied to clipboard

Allow using a proxy

Open tim95030 opened this issue 9 years ago • 7 comments

I added this in a way that nothing is affected unless you define a proxy with PGoApi.set_proxy or by passing in a proxy to the PGoApiRequest method. I defaulted it to None and it uses the standard requests library if it is none.

tim95030 avatar Aug 02 '16 17:08 tim95030

Can you please check why travis-ci is failing?

tejado avatar Aug 03 '16 12:08 tejado

I have been working on that. It appears to be an issue with Python3, but I don't know how to fix it yet. I haven't had time to figure this out at the moment. I should be able to this weekend.

tim95030 avatar Aug 03 '16 17:08 tim95030

The current requests library supports proxies and socks. http://docs.python-requests.org/en/master/user/advanced/#proxies

DSlayerMan avatar Aug 03 '16 19:08 DSlayerMan

Ok. I will fix it up to use requests[socks] then. Didn't realize they added that.

tim95030 avatar Aug 03 '16 23:08 tim95030

@tim95030 check your fb messages

beeblebox avatar Aug 04 '16 19:08 beeblebox

I think, the authentification should also use the proxy.

ndurchx avatar Aug 05 '16 07:08 ndurchx

@ndurchx What do you mean? All requests use the proxy with this change. You turn on the proxy and all requests use it. If you mean it should support proxies with authentication, then that was not my goal and can be added later separately.

tim95030 avatar Aug 05 '16 17:08 tim95030