tedious icon indicating copy to clipboard operation
tedious copied to clipboard

chore: error handling for domainToASCII

Open MichaelSun90 opened this issue 1 year ago • 1 comments

switch from punyCode to node:url introduce a behavior difference: https://github.com/tediousjs/tedious/pull/1597#issuecomment-1953027053

This fix the behavior and add test cases related to this.

MichaelSun90 avatar Feb 28 '24 21:02 MichaelSun90

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.24%. Comparing base (7e84a2f) to head (9284dc3).

Files Patch % Lines
src/connector.ts 50.00% 0 Missing and 1 partial :warning:
src/sender.ts 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
+ Coverage   79.17%   79.24%   +0.06%     
==========================================
  Files          93       93              
  Lines        4860     4861       +1     
  Branches      934      934              
==========================================
+ Hits         3848     3852       +4     
+ Misses        710      701       -9     
- Partials      302      308       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 29 '24 18:02 codecov[bot]