teddav
teddav
@benesjan thanks for the review! I just pushed a new commit with the changes. Added E2E tests, and left some `dust` on the contract to avoid resetting `balanceOf` storage slots
Thanks for the review @LHerskind . I made some changes based on your comments. Others, I think are not necessary. I still have some changes to do, and to write...
@LHerskind let me know when you have time to go over my changes/comments
@LHerskind just pushed some changes
@LHerskind im good :)
Thanks for the review @Evalir ! I think I mostly managed to make everything work, but I still have an issue. You can see it here: https://github.com/foundry-rs/foundry/pull/4931/files#diff-adc09d8ab1c41936c5b0de46796293527cd70c1a67dc170b44030830658b2053R107 In the "test_execute_signed_tx_with_revert"...
the branch was getting a bit old, so i just rebased on master
That's weird @wighawag it doesnt crash for me, and I cant reproduce a crash. The test does fail though if you don't run a node because Foundry automatically deploys create2factory...
@wighawag this should be fixed. sorry for taking so long. it was a stupid mistake, the transaction was always considered as a `Call` whatever the `to` field was. Now it's...
Hey @LeoPapais ! I'm glad you're interested in it. I am too ahah 😁 No challenge, the cheatcode is ready and working. Unfortunately, it was never reviewed a few months...