TCPDF icon indicating copy to clipboard operation
TCPDF copied to clipboard

Fix: #553

Open lpetrora opened this issue 2 years ago • 4 comments

Fix: #553

lpetrora avatar Mar 24 '23 14:03 lpetrora

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Leonardo Petrora seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 24 '23 14:03 CLAassistant

I have already signed the CLA but the status is still pending. I tried to recheck but there is no change

lpetrora avatar Mar 24 '23 16:03 lpetrora

Please edit the description to use Fixes: #553 or Fix: #553

williamdes avatar Mar 24 '23 16:03 williamdes

to bypass this you have to add a helper variable like

			$gdfunction = 'imagecreatefrom'.$type;
			$silenceGdfunction = $type === 'png';
			...
					// GD library
					$img = $silenceGdfunction ? @$gdfunction($file) : $gdfunction($file);

but i have no idea if silencing a method was, is oder ever will be a good decision.

THenkeDE avatar Sep 11 '23 14:09 THenkeDE