python-patch icon indicating copy to clipboard operation
python-patch copied to clipboard

fromfile() should either return None or raise an exception, not return False

Open stefanoborini opened this issue 7 years ago • 0 comments

It makes little sense to change the return type of fromfile. Either it's an object (or None if it fails) or it raises an Exception if it fails. Returning an object or a boolean if fails is inconsistent.

stefanoborini avatar Jan 14 '19 14:01 stefanoborini