python-patch
python-patch copied to clipboard
fromfile() should either return None or raise an exception, not return False
It makes little sense to change the return type of fromfile. Either it's an object (or None if it fails) or it raises an Exception if it fails. Returning an object or a boolean if fails is inconsistent.