PDMP3

PDMP3 copied to clipboard

I dumped the raw output to a file and now I want to convert this file to .wav with ffmpeg: ``` ffmpeg.exe -f s8 -ar 44000 -ac 2 -i result.txt...

Dingo64

adalinbv

output has audible artefacts

5

I got the library to work, by reverting to the older commit before the streaming functions were added. i can decode an MP3 ok, unfortuantely there are noticable 'scratchy' type...

audioboy77

Overflow at Requantize_Process_Short / Requantize_Process_Long

5

The given `sfb` can be 21 or 12, which exceeds as an index of `g_main_data.scalefac_l[gr][ch]` or `g_main_data.scalefac_s[gr][ch]`. I tested with an MP3 file at http://publicdomain4u.com/new-sound-for-an-old-baseball-classic

hajimehoshi

https://github.com/technosaurus/PDMP3/blob/master/pdmp3.c#L569 I guess `+2261` should be `+2773`.

hajimehoshi

https://github.com/technosaurus/PDMP3/blob/master/pdmp3.c#L1920 I'm not confident but the index for `count1` should be inverted? So the above line should be ``` max_pos = id->g_side_info.count1[gr][!(id->g_side_info.count1[gr][0] > id->g_side_info.count1[gr][1])]; ```

hajimehoshi

is_ratio_l/r in Stereo_Process_Intensity_Short are not used

1

It looks like variables `is_ratio_l` and `is_ratio_r` are just assigned but not used anywhere.

hajimehoshi

Code optimization and cleanup

1

Lots of room for improvement. 1. Floating point constants should be 0.0f (float) vs. 0.0 (double) for faster float ops 2. slow math ops like sin, cos & pow should...

technosaurus