Hackbook icon indicating copy to clipboard operation
Hackbook copied to clipboard

<a> tag optimization

Open MaximilianoCabreraP opened this issue 2 years ago • 4 comments

I want to fix the tag and apply it to the entire container

MaximilianoCabreraP avatar Oct 17 '23 17:10 MaximilianoCabreraP

@MaximilianoCabreraP give the better explanation of exactly what you want to do by reflecting the differences between existing behaviour and expected behaviour Add the screenshots as well if possible

ashish-gopalika avatar Oct 18 '23 13:10 ashish-gopalika

Sorry, you're right, but now I see the code has changed, what I suggest is that the entire card has the option to function as an anchor and not transform the pointer, since it only redirects if you click on the github button

I attach an image of the only point where the redirect acts image

I take this opportunity to ask, would you prefer that I create the issue or create the PR directly?

MaximilianoCabreraP avatar Oct 19 '23 11:10 MaximilianoCabreraP

@MaximilianoCabreraP what I can understand is that you are suggesting that the cursor should only changes while hovering over github button and not on the entire container. Right??

ashish-gopalika avatar Oct 19 '23 14:10 ashish-gopalika

mm I suggest all cards have tag, it will be easier for users to click on it.

I can do the PR and if you see it ok, you can merge it

MaximilianoCabreraP avatar Oct 19 '23 15:10 MaximilianoCabreraP