import icon indicating copy to clipboard operation
import copied to clipboard

Refactor PAC-96 image override option

Open pathmissing opened this issue 5 years ago • 0 comments

PAC-96 introduced a new option which allows overriding already existing images. In order to stay backwards compabile, new methods and attributes were made private in
src/Subjects/FileUploadTrait.php. These should be either public or protected.

Additionally, a new constant OVERRIDE_IMAGES should be introduced in the ConfigurationKeys utility class for components using the new option:

  • techdivision/import-attribute
    • src/Subjects/OptionSubject.php
    • src/Utils/ConfigurationKeys.php
  • techdivision/import-category
    • src/Subjects/BunchSubject.php
    • src/Utils/ConfigurationKeys.php
  • techdivision/import-product
    • src/Subjects/BunchSubject.php
    • src/Utils/ConfigurationKeys.php

The necessary changes are highligted as "TODOs" in the corresponding files.

pathmissing avatar May 22 '20 09:05 pathmissing