Tom Close

Results 150 comments of Tom Close

> [7fd0848](https://github.com/nipype/pydra/commit/7fd0848fec5c9d16eede8fde6ae4e0050f02593f) Ah, it was me!

Need a proper test of that error message, sorry. However, it looks like that error is covering an underlying error retrieving the runnable tasks...

See #623 for a simple fix of this issue. The traceback on the underlying error (with error message) is ``` inputs: id: timepoint0group0member0 errors: time of crash: 20230303-100710 login name:...

Not sure. There is quite a bit involved. The fact that it is every node in the workflow is puzzling me though as they wouldn't all share a common input......

> Is there a set involved? Could be an item ordering issue. Come to think of it, the problem reoccurred after I switched to using `fileformats`, which stores the fspaths...

> i don't see anything obvious between `0.20` and `0.21` that could explain the issue... I could be wrong about that. I started noticing the issue around the time I...

> I don't know its underlying implementation, but if a `frozenset` wraps a `set`, then its element ordering is determined by `PYTHONHASHSEED`. So it can be consistent within a process,...

I will explicitly implement the `__hash__` method on FileSet and see if that fixes the problem

Would still leave it as a bit of a vulnerability with the engine as a whole if you can't use inputs containing `sets`

Wouldn't ```python def __hash__(self): return hash(hash(i) for i in sorted(self)) ``` work?