python-ring-doorbell icon indicating copy to clipboard operation
python-ring-doorbell copied to clipboard

Add support for knock detection

Open craigrouse opened this issue 1 year ago • 2 comments

The Ring peephole/door view cam has a "knock detection" feature that triggers a ding when it detects a door knock. It triggers a type of API event called "door_activity" (lovely, descriptive name ;)), but to all intents and purposes, it is really a ding, and should be treated as such. It's implemented in another library here: https://github.com/dgreif/ring/blob/main/packages/ring-client-api/ring-types.ts. Because this library doesn't expose the door_activity event, any integration depending on it, such as the Home Assistant integration, doesn't get visibility of this event at all.

craigrouse avatar Jun 11 '24 19:06 craigrouse

Update: I found that door_activity is in fact exposed to HA - I'd just misread the code. It's not, however, represented in the enum for RingEventKind in this library, which I think is still relevant.

craigrouse avatar Jun 11 '24 20:06 craigrouse

Hi there, apologies for the late response as I've had make a bunch of changes to support the new ring event system. Do you still want this feature? Would you be able to test out the change for me?

sdb9696 avatar Aug 29 '24 18:08 sdb9696

There hasn't been any activity on this issue recently. This issue has been automatically marked as stale because of that. It will be closed if no further activity occurs. Please make sure to update to the latest ring_doorbell version and check if that solves the issue. Thank you for your contributions.

github-actions[bot] avatar Nov 28 '24 00:11 github-actions[bot]