python-ring-doorbell icon indicating copy to clipboard operation
python-ring-doorbell copied to clipboard

Add new device kinds (such as Doorbell 4, Doorbell Wired, Floodlight Pro)

Open samyun opened this issue 3 years ago • 1 comments

Used the list in the Hubitat Ring integration (https://github.com/HubitatCommunity/hubitat_ring_integration/blob/master/src/apps/unofficial-ring-connect.groovy) that I previously contributed to (https://github.com/HubitatCommunity/hubitat_ring_integration/commit/0456ea79fe93319923b8c90a8d19fb7600ad553e).

I have firsthand confirmation the Floodlight Pro is of kind floodlight_pro, which is my main motivation for this PR. But I figured that while I was at it, I might as well compare and see what else is missing and fill those in.

Ran the black linter, which put the FLOODLIGHT_CAM_KINDS on its own lines. Other than that, there were a handful of existing linting bugs from code I didn't touch.

samyun avatar Jun 04 '22 04:06 samyun

Wow, I totally missed #260. @tchellomello can we get one of these (or both) merged in?

samyun avatar Jun 04 '22 04:06 samyun

Spotlight Cam Pro and Doorbell 4 still not implemented. Is this ring integration really dead ?

egelinotte avatar Jul 29 '23 20:07 egelinotte

Hi @samyun. Thanks for this PR, I used it as the basis for https://github.com/tchellomello/python-ring-doorbell/pull/310 to add these and a few other devices to the library. Hence I'm closing this PR. Let me know if you have any issues with the latest version with any of your newer devices kinds. Thanks!

sdb9696 avatar Nov 27 '23 09:11 sdb9696