python-ring-doorbell icon indicating copy to clipboard operation
python-ring-doorbell copied to clipboard

Ring alerts API (active dings) is not device specific

Open ZachBenz opened this issue 6 years ago • 2 comments

Currently, the alert/active dings API is used in a per-device check_alerts method. An issue with this is that the Ring alerts API is not device specific - that is, when querying it, you get the most recent active alert across any device associated with the Ring account. Thus, for example, when calling check_alerts on a doorbell, the alert you get back may in fact be for a completely different device.

I see at least two possible ways to address this:

  1. Migrate check_alerts up from being a device specific call to being a global call
  2. Keep check_alerts where it is, but filter out alerts if they aren't for the device being queried

ZachBenz avatar Jan 03 '20 15:01 ZachBenz

I'm going to take a crack at option 2 (keep check_alerts where it is for now, filter results) and see how that works out.

ZachBenz avatar Jan 08 '20 03:01 ZachBenz

This happens if you have multiple Ringdoorbells The issue is located on #138 @tchellomello has to sort the IDs by order to have them fixed in position

nuketownhf avatar Jan 23 '20 09:01 nuketownhf

There hasn't been any activity on this issue recently. This issue has been automatically marked as stale because of that. It will be closed if no further activity occurs. Please make sure to update to the latest ring_doorbell version and check if that solves the issue. Thank you for your contributions.

github-actions[bot] avatar Apr 18 '24 18:04 github-actions[bot]