dark-plus-syntax icon indicating copy to clipboard operation
dark-plus-syntax copied to clipboard
verified publisher icon tcd

[BUG] action icons in Git view are too dark when selected

Open tennox opened this issue 3 years ago • 2 comments

Bug

image

Describe the bug

I'm using the light-plus-syntax (high contrast) theme

In source control view, when clicking a file, the icons don't change to white.

This does actually happen in the upstream (I guess it's upstream) Light+

Relevant Information

VSCode

  • Track: VSCodium (standard)
  • Version: Version: 1.68.1 (Commit: 30d9c6cd9483b2cc586687151bcbcd635f373630) Date: 2022-06-16T00:18:08.407Z Electron: 17.4.7 Chromium: 98.0.4758.141 Node.js: 16.13.0 V8: 9.8.177.13-electron.0 OS: Linux x64 5.18.5-200.fc36.x86_64
  • Extensions: dunstontc.dark-plus-syntax v0.2.8

tennox avatar Jun 22 '22 14:06 tennox

@tennox Agreed. Plan on fixing it. Pushing out some changes to day; will try to address this (most likely in v0.2.10)

tcd avatar Oct 13 '22 14:10 tcd

@tennox Addressed the issue in v0.2.11:

image

I noted in the changelog that I'm going to review ui/general colors for all themes soon to weed out any more issues like this.

tcd avatar Oct 18 '22 14:10 tcd