bolt-python icon indicating copy to clipboard operation
bolt-python copied to clipboard

Changed default Boltfile to boltfile.py

Open skoczen opened this issue 14 years ago • 3 comments

Hello,

  1. Bolt is flat-out amazing. It solves all of the fabric problems I was about to sit down and try to solve, and a few I hadn't thought of yet. Thanks for it.
  2. I'm sure your choice was intentional, but thought I'd toss this pull your way anyway. Since the Boltfile is python, it makes sense for it to end in .py, and convention indicates lowercase.

This pull just changes the default and updates the helpstring.

No offense taken if you prefer Boltfile, but given the good rationale you laid out for your fab fork changes, I would be curious to learn why it's your preference.

Thanks again, -Steven

skoczen avatar Oct 18 '11 04:10 skoczen

Hey Steven,

Thanks for the kind words about Bolt. The choice of Boltfile was very much intentional and for the following reasons:

  • You can have Boltfile and any application Python code in the same directory and use *.py without also including the boltfile.
  • It was in line with the existing tradition set by Makefile.

I did also consider supporting boltfile.py, but decided to keep things simple with just one variant. However, if you would like the option of also using boltfile.py, I would be happy to accept a pull request which handled both variants.

-- Cheers, tav

tav avatar Oct 22 '11 13:10 tav

Hey Tav,

Sounds reasonable. I'll get a pull together to support both files sometime soon.

Thanks! -Steven

skoczen avatar Oct 29 '11 23:10 skoczen

Hi Tav,

Updated to accept both. It seems a bit hacky to me, but I don't see any way to allow multiple defaults for the same parameter. If you have a better idea, point me in that direction, and I'll be happy to implement it.

-Steven

skoczen avatar Oct 30 '11 01:10 skoczen