tao icon indicating copy to clipboard operation
tao copied to clipboard

feat: added text support to system tray - macos, closes #65

Open BenJeau opened this issue 4 years ago • 1 comments

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Docs
  • [ ] New Binding issue #___
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change?

  • [ ] Yes, and the changes were approved in issue #___
  • [x] No

Checklist

  • [x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • [x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • [x] I have added a convincing reason for adding this feature, if necessary

Other information

Here's an example of the change, closes #65

https://user-images.githubusercontent.com/22248828/163900111-fadff001-1de9-42e6-b4d1-1332c0eb2985.mov

As this is my first contribution to tauri, please let me know of anything that needs to be done/changed for this to be accepted to be merged

BenJeau avatar Apr 19 '22 01:04 BenJeau

this looks very promising, is there any way I can test this in my app? :)

patrick91 avatar Aug 07 '22 18:08 patrick91

Since I'm waiting for this feature as well I created a new PR https://github.com/tauri-apps/tao/pull/554

The changes are the same as in this PR, I've just moved things to the existing traits as @amrbashir suggested and added support for the builder variant.

vojty avatar Sep 09 '22 07:09 vojty

closing in favor of #554. Thanks @BenJeau and @vojty

amrbashir avatar Sep 10 '22 18:09 amrbashir