dune-release icon indicating copy to clipboard operation
dune-release copied to clipboard

Release name is sometimes null, sometimes empty

Open emillon opened this issue 5 years ago • 3 comments

Hi,

On the github graphql API there are two notions of release names, the name of the tag, and a "name" (I think the latter is used for code names rather than version names).

It seems that something in dune-release has changed in the way it handles that field (assuming each version was released by itself):

query {
  repository(owner: "ocamllabs", name: "dune-release") {
    releases(first: 3, orderBy: {field: CREATED_AT, direction: DESC}) {
      nodes {
        tagName
        name
      }
    }
  }
}

:fast_forward:

{
  "data": {
    "repository": {
      "releases": {
        "nodes": [
          {
            "tagName": "1.4.0",
            "name": ""
          },
          {
            "tagName": "1.3.3",
            "name": null
          },
          {
            "tagName": "1.3.2",
            "name": null
          }
        ]
      }
    }
  }
}

I think that it should always be null. I'm not exactly sure what's causing this, because ocamlformat 0.15.0 (which I released with dune-release 1.4.0) has a null name :thinking: .

cc @NathanReb

emillon avatar Sep 10 '20 15:09 emillon

This field is not set when executing the curl request, it's possible the github api itself chose to change the default value from null to the empty string when the field is missing. I can't find a changelog or something to check this though.

gpetiot avatar Sep 10 '20 19:09 gpetiot

I released ocaml-opam/opam-compiler 0.1.0 this morning using a freshly installed dune-release.1.4.0 and it returns null, so I don't think that's the reason.

emillon avatar Sep 11 '20 11:09 emillon

That's weird, we should try with master just to make sure we didn't recently introduced that bug.

NathanReb avatar Sep 15 '20 08:09 NathanReb