Tapio Schneider
Tapio Schneider
> > 3\. Many other parameters can plausibly be different for different model components. For example, the Smagorinsky coefficient for an atmosphere and ocean model may well be different. We...
I agree that testing hard-coded values is not useful. (And I would remove things like the test for length of (anomalistic) year that tests that this is 325.26*days. There are...
I'm generally in favor of clear (and often that means verbose) variable and parameter names (and way back when wrote something to that effect in the CliMA roadmap). However, readability...
We discussed this. There are two classes: * Parameters that are derived from given parameters, with a functional form that is universally fixed in the model; we should make those...
(Being able to specify expressions in the TOML file would be nice. But I'm concerned that an attempt of making something maximally flexible delays getting something to work.)
Isn't the fix you had, setting `q_tot = max(0, q_tot)` for thermodynamics only, taking care of this?
> @tapios, I think we spoke about this, the current implementation uses `ΔT < tol`, not `ΔT/T < 1e-4`, is this okay? If not, we can add this capability into...
See the atmosphere design doc about how and why latent heats are combined in Clausius-Clapeyron (it's to interpolate between saturation over ice vs over liquid, using the liquid fraction).
@sriharshakandala I left a few additional comments on the other (merged PR). Could you incorporate them here and try out how it affects results?
Nice. Thank you for the detailed plan!