config icon indicating copy to clipboard operation
config copied to clipboard

Improved cmake build to build without to checkout "external/json" manually

Open Bjoe opened this issue 4 years ago • 2 comments

This PR will fix the problem, if you would like to build these project against an already installed JSON "lib"/header. Also I implemented a solution to "fetch" the sources without to fetch the sources "manually" into external/json

Bjoe avatar Apr 20 '21 15:04 Bjoe

Codecov Report

Merging #5 (c11299d) into master (341b6ce) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   64.96%   64.97%   +0.01%     
==========================================
  Files         107      107              
  Lines        2189     2187       -2     
==========================================
- Hits         1422     1421       -1     
+ Misses        767      766       -1     
Impacted Files Coverage Δ
include/tao/config/schema/internal/grammar.hpp 34.48% <0.00%> (-0.35%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 341b6ce...c11299d. Read the comment docs.

codecov-commenter avatar Apr 20 '21 16:04 codecov-commenter

Unfortunately there is following in your JSON (also PEGTL) project:

In the JSON project you "alias" the JSON target from taocpp-json to ``taocpp::json. But when you "install" the lib/header and provide the cmake config-modul, the target is exported as taocpp::taocpp-jsonbecause when you "export" the project it will be exported with the given namespace frominstall(EXPORT ..... NAMESPACE ....)in your solution it istaocpp::plus the target name, in your solutiontaocpp-json. The result is taocpp::taocpp-json`

Bjoe avatar Apr 20 '21 20:04 Bjoe