python-tidal icon indicating copy to clipboard operation
python-tidal copied to clipboard

Bug: audio_modes is a list but is linted as Optional[str]

Open GioF71 opened this issue 1 year ago • 5 comments

Apologies if this somehow duplicates my previous issue, but I see from album.py that the attribute audio_modes should be Optional[str] However, testing the type from code, I see it is actually a list, which then contains typically one str. Thank you for any feedback!

GioF71 avatar May 06 '24 14:05 GioF71

Yes, this looks like a bug.

tehkillerbee avatar May 06 '24 15:05 tehkillerbee

Thank you very much!

GioF71 avatar May 06 '24 15:05 GioF71

sorry, the bug is in the linting or in the implementation that returns the list? Given the name is plural, I would say it's in the linting, am I right?

GioF71 avatar May 06 '24 15:05 GioF71

Yes, looks like the linting is incorrect, as more than one audio type can be returned in the list.

tehkillerbee avatar May 06 '24 15:05 tehkillerbee

Ok perfect, thank you again!

GioF71 avatar May 06 '24 15:05 GioF71