coffee-maven-plugin icon indicating copy to clipboard operation
coffee-maven-plugin copied to clipboard

Develop

Open thrykol opened this issue 13 years ago • 4 comments

Added support for a node js compiler on Linux systems. Compiler used is determined by a factory which will check the OS and the existence of the 'sh', 'cat', and 'coffee' commands. If all requirements are met, the node.js compiler will be used, otherwise it defaults back to the Rhino compiler.

On my machine, the build time was reduced by about 63% when using the node path.

thrykol avatar Dec 29 '12 16:12 thrykol

Mark Derricutt » coffee-maven-plugin #18 SUCCESS This pull request looks good (what's this?)

buildhive avatar Dec 29 '12 16:12 buildhive

Hi there - started to take a look at this - good stuff! I've been meaning to implement something like this for awhile to speed up our own builds.

One thing thou, I'm not sure I like the fact its tied specifically to linux, so I'm likely to merge this to a feature branch and introduce support for the maven-toolchains-plugin which I'd been meaning to integrate for awhile.

This gives an OS neutral way to locate node be it on Linux, OSX etc. and also makes it specifically clear that you want the project to build with node, or in our case - a customized spidermonkey build ).

talios avatar Jan 03 '13 00:01 talios

I also have a local branch which removes Rhino in favor of dyn.js which is getting closer to being merged, so this refactoring will help with this as well for a transition period.

talios avatar Jan 03 '13 00:01 talios

Glad you like it. I work in a Linux environment and wanted to make sure things continued to work for all other environments. Thus the factory which defaults back to Rhino if the requirements aren't met. I agree that it should be more OS independent. The more versatile it can be made, the better.

thrykol avatar Jan 03 '13 00:01 thrykol