python-teos icon indicating copy to clipboard operation
python-teos copied to clipboard

Get rid of OrderedDicts

Open sr-gi opened this issue 5 years ago • 6 comments

The minimum required Python version will be bumped to 3.7 with release v0.1.1.

With Python 3.7, dicts preserve inclusion order, so there will be no need for OrderedDicts anymore within the codebase (given that the former are much faster).

sr-gi avatar Sep 23 '20 21:09 sr-gi

I could do that, if no one has started yet

cedric-audy avatar Nov 12 '20 04:11 cedric-audy

Welcome @cedric-audy, feel free to take it, no one is working on this atm.

sr-gi avatar Nov 12 '20 11:11 sr-gi

@cedric-audy are you working on this? or may I begin working on it now?

ritikramuka avatar Feb 22 '22 11:02 ritikramuka

hi there, @sr-gi I searched the codebase for the term OrderedDicts but couldn't find it. So, could you please advise me on how to proceed?

ritikramuka avatar Feb 22 '22 11:02 ritikramuka

Hi @ritikramuka, happy to see you're showing interest to contribute to teos.

The only instances of OrderedDict in the codebase should be in the LocatorCache located in the Watcher.

I wanted to let you known, though, that this codebase will be deprecated in the upcoming weeks, in favor of https://github.com/sr-gi/rusty-teos (the Rust port of it).

I'm planning on tackling some issues in this Python version and leave it at a final stable version, but all future development may only take place in rust-teos.

Having said that, you're welcome to tackle this if you'd like to get familiar with the codebase, and more than welcome to contribute to rust-teos once the first alpha is released.

sr-gi avatar Feb 22 '22 11:02 sr-gi

Hi @sr-gi I tried to install all the requirements listed in CONTRIBUTING.md but running pytest gives the below

test/common/unit/conftest.py:5: in <module>
    from common.db_manager import DBManager
common/db_manager.py:2: in <module>
    import plyvel
E   ModuleNotFoundError: No module named 'plyvel'

then I tried installing requirements.txt which contains plyvel package but got this error

ERROR: Failed building wheel for plyvel

ritikramuka avatar Feb 22 '22 18:02 ritikramuka