mkctr icon indicating copy to clipboard operation
mkctr copied to clipboard

Mixup between OCI and Docker layer formats

Open zyclonite opened this issue 2 years ago • 2 comments

Since stable version 1.44.0 it seems the manifest is broken... some clients ignore that fact but buildah breaks with the following error:

error creating build container: error preparing image configuration: error converting image "containers-storage:[overlay@/home/runner/.local/share/containers/storage+/run/user/1001/containers]@1a00a379b1b45b5f5a1d19e230b108ed0cd8c189fc593f5d2a079b9ea9fd6aa9" from "application/vnd.oci.image.manifest.v1+json" to "application/vnd.docker.distribution.manifest.v2+json": Unknown media type during manifest conversion: "application/vnd.docker.image.rootfs.diff.tar.gzip"

after some research it looks like the issue is similar to https://github.com/containers/buildah/issues/3668

i did compare v1.42.0 and v1.44.0 and see the sub manifest media type changed

v1.42.0

{
  "schemaVersion": 2,
  "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
  "manifests": [
    {
      "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
      "size": 756,
      "digest": "sha256:5564844986abed0569fad566752215c8c86cf8d279d05806f521aa4614c04c28",
      "platform": {
        "architecture": "arm64",
        "os": "linux"
      }
    },
...

v1.44.0

{
  "schemaVersion": 2,
  "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
  "manifests": [
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "size": 728,
      "digest": "sha256:63e48fc5eefa389bba9aaf22d31f7b4eabf2975b0cbbd1c32327c2b571a0570a",
      "platform": {
        "architecture": "arm64",
        "os": "linux"
      }
    },
...

zyclonite avatar Jul 31 '23 20:07 zyclonite

maybe that created the issue -> https://github.com/tailscale/mkctr/commit/c4fd5c4936565517a6d12665f051466f0a5a89ef

zyclonite avatar Jul 31 '23 20:07 zyclonite

Hi @zyclonite

This should have been fixed in https://github.com/tailscale/mkctr/pull/14

unstable-v1.57.76 and later tags should have the fix and it will be included in v1.58 when we release that- let us know if it works for you!

irbekrm avatar Jan 12 '24 10:01 irbekrm

Closing as fixed

irbekrm avatar May 24 '24 17:05 irbekrm