libmount Chores: Edition 2018, quick-error -> thiserror, deps update

A bunch of chores, should be fairly well separated into individual commits.

Nov 18 '20 12:11 drahnr

Hey @tailhook, is there anything left to do here?

Nov 27 '20 06:11 drahnr

☃️ it'd be awesome if I could get some feedback on this 🙂

Dec 19 '20 14:12 drahnr

Yes, sorry. This has so much stuff, I don't have enough time to review. I'm also not sure if I agree with thiserror and fs_err. This crate has their own errors to have both, nice error messages or performance on failure path if needed.

But I still need to look at details, which I had no time to do yet. Hopefully, I'll find some time to take a look soon.

Dec 22 '20 15:12 tailhook

thiserror provides a zero overhead and zero extra weight, it's just convenience for error definition. fs_err adds path information to std::io::Error messages and does not introduce an extra error type iirc. So both are effectively no interface changes.

The rest is mostly chore.

The thing that is breaking, are the additional bounds on Box<dyn Explainable> which is now Box<dyn Explainable + Send + Sync + 'static, but I am not 100% sure about that change being needed, it was needed for the use case though I had, but that resulted in this rustc issue https://github.com/rust-lang/rust/issues/78700

Jan 21 '21 14:01 drahnr

Anything I can add or do here?

Feb 20 '21 22:02 drahnr