server-client-python icon indicating copy to clipboard operation
server-client-python copied to clipboard
verified publisher icon tableau

feat: tag everything

Open jorwoods opened this issue 1 year ago • 4 comments

Closes #1421

jorwoods avatar Jul 22 '24 12:07 jorwoods

Since workbooks, views, and data sources all follow the same pattern here, theoretically we could solve this with a Mixin class and add the functionality to all three with reduced duplication.

jorwoods avatar Jul 23 '24 00:07 jorwoods

Virtual connections also follow this pattern and could have the functionality added via a mixin class if that's the route we want to go.

jorwoods avatar Jul 30 '24 11:07 jorwoods

yes, I think that's a great idea. I'd love to get all the shared functionality actually extracted from individual objects in this code.

jacalata avatar Aug 02 '24 01:08 jacalata

After this gets merged, I can rebase #1429 and add tagging support for virtual connections as well.

jorwoods avatar Aug 02 '24 12:08 jorwoods