TabPy icon indicating copy to clipboard operation
TabPy copied to clipboard

Accept proxy setting in tabpy-deploy-models

Open ElPincheTopo opened this issue 5 years ago • 3 comments

tabpy-deploy-models runs SentimentAnalysis.py which runs:

nltk.download("vader_lexicon")
nltk.download("punkt")

This fails if you are running in environments without direct connection to the internet. nltk supports setting a proxy for the downloads, so I propose adding a cmd line argument to pass the proxy address to tabpy-deploy-models and this would pass it to all the scripts in case any other script needs it. For now, only SentimentAnalysis.py and we just need to get the cmd arg pass it to nltk.set_proxy().

I'm happy to do this but I would like to know if the team behind TabPy likes the approach and would accept my Pull request.

ElPincheTopo avatar Jan 14 '21 08:01 ElPincheTopo

@ElPincheTopo Yes, the team behind TabPy would love any improvements!

0golovatyi avatar Jan 14 '21 19:01 0golovatyi

I submitted a pull request with my proposed changes: https://github.com/tableau/TabPy/pull/471

ElPincheTopo avatar Jan 14 '21 22:01 ElPincheTopo

It's taken some time, but we are reviewing this now.

nmannheimer avatar Jun 14 '22 22:06 nmannheimer