txAdmin icon indicating copy to clipboard operation
txAdmin copied to clipboard

tweak(client/cl_spectate): Make gamer tag tickless

Open Ekinoxx0 opened this issue 3 years ago • 4 comments

Make cl_spectate tickless

This was kinda bothering me while profiling my server that doesn't use monitor, so I made this part of the code tickless

Ekinoxx0 avatar Jun 20 '22 20:06 Ekinoxx0

@TasoOneAsia b-but... conflict with your own pr

tabarra avatar Jun 22 '22 23:06 tabarra

I could re-do/change this PR if needed after his commit is merged first, just need to know if something is blocking the merge of #591 🤔

Ekinoxx0 avatar Jun 30 '22 00:06 Ekinoxx0

Right now merging any client side lua is very risky because errors wont be printed, so we will have really hard time finding out and fixing issues.
It will take a few more months until we can merge that.

tabarra avatar Jun 30 '22 00:06 tabarra

Seems understandable, implementing some sort of trycatch functions could be a solution with error handling being reported through a sentry. I suppose it would need approval from the Cfx team

Anyway I will keep following both PR and modifying them if needed 👍

Ekinoxx0 avatar Jun 30 '22 00:06 Ekinoxx0

Thanks for the PR.
Due to conflicts I'm merging it manually.

tabarra avatar Mar 26 '23 16:03 tabarra