Bohan Zhang

Results 55 comments of Bohan Zhang

> Great initiative, love it! Our company's policy is to have all commits signed, so I'd be grateful if you could redo your commits signed. To fix the failing tests...

Let's merge it. Great work!

Thanks for answering the questions raised above. > > we gonna trigger a rollback in advance proactively for the promise > > What does this mean? Take the example above,...

> #16234 was closed by #16337. > > > We can keep the old code for existing users, but the default behavior should be using v2 i.e. No _v2 prefix...

> I am not sure whether the debezium format definition allows it 🤔 @tabVersion can you please take a look? yes, debezium allows this operation by specifying `key.converter.schemas.enable` and `value.converter.schemas.enable`....

> @tabVersion Hi, is there any progress on this issue, I'd like to try and help in any way I can if I can. Sorry, there's no update yet. And...

> > It seems that the `time` type ignores the millisecond part in [json encoder](https://github.com/risingwavelabs/risingwave/blob/main/src/connector/src/sink/encoder/json.rs?rgh-link-date=2023-11-24T08%3A05%3A27Z#L237)? > > Yes, and we need `TimeHandlingMode` to fix it without breaking backward compatibility. Can...

> > Just to confirm, the benefit of persisting avro/proto definition in meta is not needing to fetch it from schema registry on restart/recovery? > > It's also for consistency...

> I believe several topics need to be enriched. > > Syntax > > * What about `DROP`, `ALTER`? > * What's the behavior of `DROP`, `ALTER`? Yes, I did...